Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Have the bot label issues by type - #14698

Merged
Hainish merged 4 commits into
EFForg:masterfrom
strugee:label-type
May 16, 2018
Merged

Hainish merged 4 commits into
EFForg:masterfrom
strugee:label-type

Conversation

@strugee

@strugee strugee commented Feb 20, 2018 •

Copy link
Copy Markdown
Contributor

What the title says. Open questions:

  • ruleset enhancement as an issue type seems like a bit of a mouthful - maybe it should be "ruleset feature" or something instead, I dunno
  • There's a ruleset label but it doesn't seem to be used much. Should the bot always label ruleset issues with this label?
  • There's no general code label so I used bug and enhancement which, conveniently, there are already types for (code issue and feature request, respectively). Does that seem right?

All tests passing locally.

As usual this contains an unrelated commit (removing an outdated TODO) that didn't seem worth bothering with a separate PR for.

Ref #14616

/cc @Hainish

@strugee strugee mentioned this pull request Feb 20, 2018
5 of 16 tasks
@strugee

strugee commented Feb 21, 2018 •

Copy link
Copy Markdown
Contributor Author

@Hainish ping, when you get some spare cycles

@strugee

strugee commented Mar 2, 2018

Copy link
Copy Markdown
Contributor Author

@Hainish ping :-)

@strugee

strugee commented Mar 7, 2018 •

Copy link
Copy Markdown
Contributor Author

@Hainish ping (and sorry for the spam lol)

Comment thread .github/ISSUE_TEMPLATE.md Outdated
[//]: # (Leave in the line that best describes the issue you are reporting.)

Type: ruleset issue
Type: ruleset enhancement

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @jeremyn's comment in #13890 (comment) is fair: we should probably reduce the overhead and only have a ruleset issue and new ruleset sub-tier label, both of which would get the ruleset label.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hainish whoops, this fell off my radar somehow. Fixed.

@Bisaloo

Bisaloo commented Mar 21, 2018

Copy link
Copy Markdown
Collaborator

@strugee, this recent email from the dev mailing list is relevant here: the ruleset label has been deleted.

The ruleset issue issues should probably now use ruleset-bug.

@strugee

strugee commented Apr 11, 2018

Copy link
Copy Markdown
Contributor Author

I emailed the list to solicit feedback about this: https://lists.eff.org/pipermail/https-everywhere/2018-April/002777.html

strugee added a commit to strugee/https-everywhere that referenced this pull request May 16, 2018
As noted in
EFForg#14698 (comment),
the omnibus `ruleset` label has been removed. Therefore undo some of
the earlier changes and instead use `ruleset-bug` and `new-ruleset`
again. `ruleset-enhancement` is not used since as noted in
EFForg#14698 (comment),
this can be too much overhead for contributors.
@strugee

strugee commented May 16, 2018

Copy link
Copy Markdown
Contributor Author

I emailed @Hainish this evening and realized that once again I'd forgotten about this PR! Since I never got any explicit feedback on the mailing list I just went with what was sensible while not adding any more issue types. See the commit message in 5a9dce2 for details.

This is ready for review again.

strugee added 4 commits May 16, 2018 01:17
As noted in
EFForg#14698 (comment),
the omnibus `ruleset` label has been removed. Therefore undo some of
the earlier changes and instead use `ruleset-bug` and `new-ruleset`
again. `ruleset-enhancement` is not used since as noted in
EFForg#14698 (comment),
this can be too much overhead for contributors.
@strugee

strugee commented May 16, 2018

Copy link
Copy Markdown
Contributor Author

I just rebased this on top of master too.

@Bisaloo

Bisaloo commented May 16, 2018

Copy link
Copy Markdown
Collaborator

The labels look fine to me. Thank you!

@strugee

strugee commented May 16, 2018

Copy link
Copy Markdown
Contributor Author

@Bisaloo great! What do you think of the note to ping me? Too noisy?

One thing that wouldn't be too hard to do is make it so that the bot e.g. only commented this once in a given thread. It would be more difficult but we should also be able to do behaviors like "every other comment in a thread". I've included information so that we can do that now or later if desired.

@Bisaloo

Bisaloo commented May 16, 2018

Copy link
Copy Markdown
Collaborator

I'm sorry, I'm not sure what you're referring to.

@strugee

strugee commented May 16, 2018

Copy link
Copy Markdown
Contributor Author

@Bisaloo ahaha, so sorry! I mixed up the PR where I made that change. I thought it was in this one, but it was actually in #15439 instead. My bad :D

@Hainish
Hainish merged commit 95572c5 into EFForg:master May 16, 2018
@Hainish

Hainish commented May 16, 2018

Copy link
Copy Markdown
Member

Thank you!

@strugee
strugee deleted the label-type branch May 17, 2018 00:27
@strugee

strugee commented May 17, 2018

Copy link
Copy Markdown
Contributor Author

@Hainish my pleasure!

@strugee

strugee commented May 17, 2018

Copy link
Copy Markdown
Contributor Author

And do let me know if it's helpful or if you run into problems :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants