Repository navigation
Have the bot label issues by type - #14698
Conversation
|
@Hainish ping, when you get some spare cycles |
|
@Hainish ping :-) |
|
@Hainish ping (and sorry for the spam lol) |
| [//]: # (Leave in the line that best describes the issue you are reporting.) | ||
|
|
||
| Type: ruleset issue | ||
| Type: ruleset enhancement |
There was a problem hiding this comment.
I think @jeremyn's comment in #13890 (comment) is fair: we should probably reduce the overhead and only have a ruleset issue and new ruleset sub-tier label, both of which would get the ruleset label.
There was a problem hiding this comment.
@Hainish whoops, this fell off my radar somehow. Fixed.
|
@strugee, this recent email from the dev mailing list is relevant here: the The |
|
I emailed the list to solicit feedback about this: https://lists.eff.org/pipermail/https-everywhere/2018-April/002777.html |
As noted in EFForg#14698 (comment), the omnibus `ruleset` label has been removed. Therefore undo some of the earlier changes and instead use `ruleset-bug` and `new-ruleset` again. `ruleset-enhancement` is not used since as noted in EFForg#14698 (comment), this can be too much overhead for contributors.
|
I emailed @Hainish this evening and realized that once again I'd forgotten about this PR! Since I never got any explicit feedback on the mailing list I just went with what was sensible while not adding any more issue types. See the commit message in 5a9dce2 for details. This is ready for review again. |
As noted in EFForg#14698 (comment), the omnibus `ruleset` label has been removed. Therefore undo some of the earlier changes and instead use `ruleset-bug` and `new-ruleset` again. `ruleset-enhancement` is not used since as noted in EFForg#14698 (comment), this can be too much overhead for contributors.
|
I just rebased this on top of |
|
The labels look fine to me. Thank you! |
|
@Bisaloo great! What do you think of the note to ping me? Too noisy? One thing that wouldn't be too hard to do is make it so that the bot e.g. only commented this once in a given thread. It would be more difficult but we should also be able to do behaviors like "every other comment in a thread". I've included information so that we can do that now or later if desired. |
|
I'm sorry, I'm not sure what you're referring to. |
|
Thank you! |
|
@Hainish my pleasure! |
|
And do let me know if it's helpful or if you run into problems :) |
What the title says. Open questions:
ruleset enhancementas an issue type seems like a bit of a mouthful - maybe it should be "ruleset feature" or something instead, I dunnorulesetlabel but it doesn't seem to be used much. Should the bot always label ruleset issues with this label?codelabel so I usedbugandenhancementwhich, conveniently, there are already types for (code issueandfeature request, respectively). Does that seem right?All tests passing locally.
As usual this contains an unrelated commit (removing an outdated TODO) that didn't seem worth bothering with a separate PR for.
Ref #14616
/cc @Hainish